Hi Dan, I am fixing the errors and warning reported by checkpatch. I have quite a few of these: ERROR: do not initialise globals to 0 or NULL #90: FILE: drivers/net/wan/farsync.c:83: +int fst_excluded_cards = 0; Is this because when the module is loaded the globals are guaranteed to be zero'd already, or is the module init is expected to initialise them? Regards Kevin -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html