Mon, Jul 29, 2013 at 09:36:51PM CEST, dan.carpenter@xxxxxxxxxx wrote: >opt.__reserved isn't cleared so we leak a byte of stack information. > >Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > >diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c >index 71a5688..6398a61 100644 >--- a/net/sched/sch_cbq.c >+++ b/net/sched/sch_cbq.c >@@ -1469,6 +1469,7 @@ static int cbq_dump_wrr(struct sk_buff *skb, struct cbq_class *cl) > opt.allot = cl->allot; > opt.priority = cl->priority + 1; > opt.cpriority = cl->cpriority + 1; >+ opt.__reserved = 0; There's probably better to zero whole opt at the beginning of the function. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
