On Wed, Jul 17, 2013 at 09:03:53AM -0600, Stephen Warren wrote: > On 07/17/2013 06:26 AM, Dan Carpenter wrote: > > "xspi->irq" is unsigned int so it's never less than zero. I have added > > a cast. > > Um. Doesn't this just hide a warning, not solve the problem? If the > value can't be negative, so the if condition never fires, then the cast > won't change that... No. It fixes the problem but Mark is right that it's ugly. Sorry for that. I will resend. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html