On Sun, Jul 14, 2013 at 11:00:58PM +0530, Vivek Subbarao wrote: > There are many places where the return value from request_region is not > checked for null value. This is required right ? I am just checking > before I can send patched fixing them Most of the time, but not always. Sometimes people know it will succeed. The first one I looked at in drivers/acpi/acpi_processor.c the caller doesn't care if it succeeds and there is a comment explaining why. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html