On Tue, Jun 18, 2013 at 1:40 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> This is a static checker fix. "size" is a u64 here, but "num_buses" is
> only 32 bits so we would hit shift wrapping bugs trying to use larger
> sizes.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/arch/x86/pci/mmconfig_64.c b/arch/x86/pci/mmconfig_64.c
> index bea5249..430ed2b 100644
> --- a/arch/x86/pci/mmconfig_64.c
> +++ b/arch/x86/pci/mmconfig_64.c
> @@ -98,8 +98,7 @@ const struct pci_raw_ops pci_mmcfg = {
> static void __iomem *mcfg_ioremap(struct pci_mmcfg_region *cfg)
> {
> void __iomem *addr;
> - u64 start, size;
> - int num_buses;
> + u64 start, size, num_buses;
>
> start = cfg->address + PCI_MMCFG_BUS_OFFSET(cfg->start_bus);
> num_buses = cfg->end_bus - cfg->start_bus + 1;
Is there an actual bug here? I don't see it, but I'm not a C language lawyer.
I guess I'm not necessarily opposed to changing it just to satisfy
checkers, but I'd like to be able to figure out the correct types to
use in the first place, and I don't know to figure this one out.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
