On Fri, Jun 07, 2013 at 01:44:24PM +0000, Wilcox, Matthew R wrote: > Hi Dan, > > We have to program the device with the page size so it knows where the page boundaries are. > I could put all this on one logical line like this: > > dev->ctrl_config = NVME_CC_ENABLE | NVME_CC_CSS_NVM | > ((PAGE_SHIFT - 12) << NVME_CC_MPS_SHIFT | > NVME_CC_ARB_RR | NVME_CC_SHN_NONE | > NVME_CC_IOSQES | NVME_CC_IOCQES; > > in order to shut up the warning, but is that really more readable? It wouldn't shut up the complaint either... No worries. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
