On Fri, May 31, 2013 at 09:02:11PM +0530, Harsh Kumar wrote: > Memory & urb should be freed before exiting from the function, I think. > They are freed in Wb35Reg_EP0VM_complete() so this patch will make the system crash right away. Btw, there are tons of real bugs that I know about but which I don't fix because I don't know what the right thing to do is. > Note: This patch is to be applied after applying the earlier patch i.e [patch 1/2] > In a patch series it's assumed that we have to apply them in order, but if you need to add a comment like this the right place to do it is under the --- line and before the patch. > Signed-off-by: Harsh Kumar <harsh1kumar@xxxxxxxxx> > > --- Side comments not intended for the perment git log go here. > drivers/staging/winbond/wb35reg.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
