On 05/29/2013 01:22 AM, Dan Carpenter wrote: > I introduced a new temporary variable "info" instead of > "m->m_info[mds]". Also I reversed the if condition and pulled > everything in one indent level. Looks good. I will apply this for you. Reviewed-by: Alex Elder <elder@xxxxxxxxxxx> > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > This goes on top of Emil Goode's patch. > > diff --git a/fs/ceph/mdsmap.c b/fs/ceph/mdsmap.c > index d4d3897..132b64e 100644 > --- a/fs/ceph/mdsmap.c > +++ b/fs/ceph/mdsmap.c > @@ -92,6 +92,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) > u32 num_export_targets; > void *pexport_targets = NULL; > struct ceph_timespec laggy_since; > + struct ceph_mds_info *info; > > ceph_decode_need(p, end, sizeof(u64)*2 + 1 + sizeof(u32), bad); > global_id = ceph_decode_64(p); . . . -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html