On Wed, May 29, 2013 at 09:28:43AM +0800, Chen Gang wrote: > diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c > index bae0f40..27f200d 100644 > --- a/arch/s390/appldata/appldata_base.c > +++ b/arch/s390/appldata/appldata_base.c > @@ -212,10 +212,9 @@ appldata_timer_handler(ctl_table *ctl, int write, > return 0; > } > if (!write) { > - len = sprintf(buf, appldata_timer_active ? "1\n" : "0\n"); > - if (len > *lenp) > - len = *lenp; > - if (copy_to_user(buffer, buf, len)) > + if (copy_to_user(buffer, > + appldata_timer_active ? "1\n" : "0\n", > + min(2, *lenp)) I don't have a cross compiler set up, but this will generate a warning, I think. min_t() is needed. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html