Re: [patch] ipg: fix an unsigned widening cast of '~' truncation issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Wed, 15 May 2013 10:20:02 +0300

> The bug here is this code from ipg_nic_hard_start_xmit():
> 
> 	txfd->tfc &= cpu_to_le64(~IPG_TFC_TFDDONE);
> 
> IPG_TFC_TFDDONE is 0x0000000080000000 so it's an unsigned int.  The
> negated value is 0x7fffffff but 0xffffffff7fffffff was intended.
> 
> The other values in this file don't need to be changed but I did it for
> consistency.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux