On Tue, Apr 30, 2013 at 10:28:14AM +0300, Dan Carpenter wrote: > The difference between "count" and "len" is that "len" is capped at > 4095. Changing it like this makes it match how sysfs_write_file() is > implemented. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Joel Becker <jlbec@xxxxxxxxxxxx> Do you want me to push this up, or will you be sending it? Joel > --- > This is a static analysis patch. I haven't found any store_attribute() > functions where this change makes a difference. > > diff --git a/fs/configfs/file.c b/fs/configfs/file.c > index 2b6cb23..1d1c41f 100644 > --- a/fs/configfs/file.c > +++ b/fs/configfs/file.c > @@ -203,7 +203,7 @@ configfs_write_file(struct file *file, const char __user *buf, size_t count, lof > mutex_lock(&buffer->mutex); > len = fill_write_buffer(buffer, buf, count); > if (len > 0) > - len = flush_write_buffer(file->f_path.dentry, buffer, count); > + len = flush_write_buffer(file->f_path.dentry, buffer, len); > if (len > 0) > *ppos += len; > mutex_unlock(&buffer->mutex); -- "In the room the women come and go Talking of Michaelangelo." http://www.jlbec.org/ jlbec@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
