Re: [patch] Thermal: cpufreq cooling: endian bug in cpufreq_get_max_state()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17-04-2013 11:45, Zhang Rui wrote:
On Wed, 2013-04-17 at 10:18 +0300, Dan Carpenter wrote:
This code doesn't work on big endian systems because we're storing low
values in the high bits of the unsigned long.  It makes it a very high
value instead.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

applied to thermal -next.

Rui,

Can you please add also my:
Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxx>
Tested-by: Eduardo Valentin <eduardo.valentin@xxxxxx>

Tested on TI OMAP4430.



thanks,
rui

diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 5f5c780..768b508 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -303,12 +303,12 @@ static int cpufreq_get_max_state(struct thermal_cooling_device *cdev,
  	struct cpufreq_cooling_device *cpufreq_device = cdev->devdata;
  	struct cpumask *mask = &cpufreq_device->allowed_cpus;
  	unsigned int cpu;
-	unsigned long count = 0;
+	unsigned int count = 0;
  	int ret;

  	cpu = cpumask_any(mask);

-	ret = get_property(cpu, 0, (unsigned int *)&count, GET_MAXL);
+	ret = get_property(cpu, 0, &count, GET_MAXL);

  	if (count > 0)
  		*state = count;


--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux