On 13.03.2013 06:32, Dan Carpenter wrote: > "val" has to be signed for the error handling to work. Absolutely. > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Daniel Mack <zonque@xxxxxxxxx> > > diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c > index 008bea4..41d03ae 100644 > --- a/sound/soc/codecs/tas5086.c > +++ b/sound/soc/codecs/tas5086.c > @@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream, > { > struct snd_soc_codec *codec = dai->codec; > struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec); > - unsigned int val; > + int val; > int ret; > > priv->rate = params_rate(params); > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html