On Sat, 23 Feb 2013, Dan Carpenter wrote: > On Fri, Feb 22, 2013 at 11:44:31AM +0100, Michal Marek wrote: > > On Sat, Feb 02, 2013 at 05:19:55PM +0100, Julia Lawall wrote: > > > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > > > Semantic patch (http://coccinelle.lip6.fr/) to check for constants that are > > > added but are used elsewhere as bitmasks. > > > > > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > Applied to kbuild.git#misc. > > > > I'm not sure we want to do this. The one patch which was sent with > this script wasn't applied. I think that the view on it was that if it isn't broken, don't fix it. But if the rules that are being added to the kernel are primarily being used for new code, then it could be reasonable for developers to consider whether they would really rather use | rather than the confusing +. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
