On 2013-02-22 14:26, Kumar amit mehta wrote:
On Fri, Feb 22, 2013 at 10:02:44AM +0000, Ian Abbott wrote:
On 2013-02-22 06:07, Kumar Amit Mehta wrote:
This patch fixes an instance of DMA buffer on stack(being passed to
usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
Looks good here too.
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
Would you mind doing the same for usbdux.c and usbduxfast.c?
Sure.
As pointed out by Dan, Do you really want the buffer to be of 16 bytes, as we
are using only the first byte and passing the length as '1' in:
usbduxsub_start, usbduxsub_stop, usbduxfastsub_start, usbduxfastsub_stop ?
A buffer size of 1 should be fine.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
