It's testing for ->show but calling ->store(). Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- Static analysis. I don't know if it affects real life. diff --git a/kernel/padata.c b/kernel/padata.c index 072f4ee..7ac61c1 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -1013,7 +1013,7 @@ static ssize_t padata_sysfs_store(struct kobject *kobj, struct attribute *attr, pinst = kobj2pinst(kobj); pentry = attr2pentry(attr); - if (pentry->show) + if (pentry->store) ret = pentry->store(pinst, attr, buf, count); return ret; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html