Re: [PATCH] [media] use IS_ENABLED() macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/20/2013 08:07 PM, Antti Palosaari wrote:
On 01/20/2013 07:32 AM, Peter Senna Tschudin wrote:
This patch introduces the use of IS_ENABLED() macro. For example,
replacing:
  #if defined(CONFIG_I2C) || (defined(CONFIG_I2C_MODULE) &&
defined(MODULE))

with:
  #if IS_ENABLED(CONFIG_I2C)

All changes made by this patch respect the same replacement pattern.

Reported-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>

For my drivers

  drivers/media/tuners/qt1010.h             | 2 +-
  drivers/media/tuners/xc4000.h             | 2 +-

Ooops, I messed xc4000 with e4000 driver. Anyhow, your patch is just correct what I know.


Acked-by: Antti Palosaari <crope@xxxxxx>


Why you didn't changed all those drivers as once?

I was planning to do just similar change to all dvb drivers (I did it
for DVB USB V2 remote controller already).

I have also changed some of my new driver printk() calls from these
headers to new pr/dev _foo() style. Please, could you fix it also :)

regard
Antti



--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux