On Fri, Jan 18, 2013 at 11:36:52AM -0800, Nicholas A. Bellinger wrote: > On Fri, 2013-01-18 at 16:05 +0300, Dan Carpenter wrote: > > "buf" is 128 characters and "vpd->device_identifier" is 256. It makes > > the static checkers complain. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > Applied to target-pending/for-next. > > > Probably we should just raise VPD_TMP_BUF_SIZE to 300. > > Also bumping up VPD_TMP_BUF_SIZE to 254 to match the usage with > INQUIRY_VPD_DEVICE_IDENTIFIER_LEN sized vpd->device_identifier[] below. > It could still go over 254 because it's "T10 VPD Binary Device Identifier: " plus INQUIRY_VPD_DEVICE_IDENTIFIER_LEN. But I agree that probably 254 is enough space. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
