Am 14.01.2013 21:04, schrieb John W. Linville:
> On Sun, Jan 13, 2013 at 11:03:09PM +0300, Dan Carpenter wrote:
>> There were no break statements in this switch statement so everything
>> used the default settings.
great :)
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>> ---
>> Static checker stuff. Untested.
>>
>> diff --git a/drivers/net/wireless/b43/tables_nphy.c b/drivers/net/wireless/b43/tables_nphy.c
>> index 97d4e27..6a1c838 100644
>> --- a/drivers/net/wireless/b43/tables_nphy.c
>> +++ b/drivers/net/wireless/b43/tables_nphy.c
>> @@ -3259,20 +3259,28 @@ struct nphy_gain_ctl_workaround_entry *b43_nphy_get_gain_ctl_workaround_ent(
>> switch (tr_iso) {
>> case 0:
>> e->cliplo_gain = 0x0062;
>> + break;
>> case 1:
>> e->cliplo_gain = 0x0064;
>> + break;
>> case 2:
>> e->cliplo_gain = 0x006a;
>> + break;
>> case 3:
>> e->cliplo_gain = 0x106a;
>> + break;
>> case 4:
>> e->cliplo_gain = 0x106c;
>> + break;
>> case 5:
>> e->cliplo_gain = 0x1074;
>> + break;
>> case 6:
>> e->cliplo_gain = 0x107c;
>> + break;
>> case 7:
>> e->cliplo_gain = 0x207c;
>> + break;
>> default:
>> e->cliplo_gain = 0x106a;
>> }
>
> Wow...nice find!
>
> This seems like it could be significant. Any comments from the
> b43 folks? Should this go to 3.8?
>
perhaps an array would be more simple here ?
if (tr_iso > 7 )
e->cliplo_gain = 0x106a;
{
int data[]={0x0062,0x0064,0x006a,0x106a,0x106c,0x1074,0x107c,0x207c};
e->cliplo_gain = data[tr_iso];
}
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
