On Mon, 2012-12-10 at 11:44 +0300, Dan Carpenter wrote: > On Fri, Dec 07, 2012 at 07:05:53PM -0800, H. Peter Anvin wrote: > > On 12/06/2012 10:16 PM, Dan Carpenter wrote: > > >Negate has higher precedence than bitwise AND so the condition is always > > >false. > > > > > >Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > > >diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c > > >index b1942e2..18e329c 100644 > > >--- a/arch/x86/boot/compressed/eboot.c > > >+++ b/arch/x86/boot/compressed/eboot.c > > >@@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params) > > > if (status != EFI_SUCCESS) > > > continue; > > > > > >- if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM) > > >+ if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)) > > > continue; > > > > > > if (!pci->romimage || !pci->romsize) > > > > > > > What is the baseline for this patch? > > > > Sorry, this is a linux-next bug. Introduced in: > > commit dd5fc854de5fd37adfcef8a366cd21a55aa01d3d > Author: Matthew Garrett <mjg@xxxxxxxxxx> > Date: Wed Dec 5 14:33:26 2012 -0700 > > EFI: Stash ROMs if they're not in the PCI BAR Thanks Dan, I've picked this up. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
