Dan, And will fix this too, Thanks so much, george ----- Original Message ----- > From: "Dan Carpenter" <dan.carpenter@xxxxxxxxxx> > To: georgezhang@xxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx, kbuild@xxxxxx > Sent: Thursday, January 10, 2013 11:32:39 AM > Subject: re: VMCI: queue pairs implementation. > > Hello George Zhang, > > This is a semi-automatic email about new static checker warnings. > > The patch 06164d2b72aa: "VMCI: queue pairs implementation." from Jan > 8, 2013, leads to the following Smatch complaint: > > drivers/misc/vmw_vmci/vmci_queue_pair.c:3356 vmci_qpair_dequev() > warn: variable dereferenced before check 'qpair' (see line 3354) > > drivers/misc/vmw_vmci/vmci_queue_pair.c > 3353 > 3354 qp_lock(qpair); > ^^^^^^ > dereference. > > 3355 > 3356 if (!qpair || !iov) > ^^^^^ > test. > > 3357 return VMCI_ERROR_INVALID_ARGS; > 3358 > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html