On Wed, 2012-12-12 at 00:15 -0500, David Miller wrote: > From: Cyril Roelandt <tipecaml@xxxxxxxxx> > Date: Wed, 12 Dec 2012 01:24:53 +0100 > > > The ptp_clock_register() returns ERR_PTR() and never returns NULL. Replace the > > NULL check by a call to IS_ERR(). > > > > Signed-off-by: Cyril Roelandt <tipecaml@xxxxxxxxx> > > I'll let Ben queue this up. > > Probably he'll want to avoid potentially leaving an ERR_PTR > in ptp->phc_clock even if, with this fix, that would be > harmless. Sorry for the delay in looking at this. This change is fine, as the entire structure *ptp will be freed on the failure path. I'm now on vacation until the new year. Cyril, please re-send your patch with the addition of: Acked-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> so it will show up on 'patchwork' again and David can apply it from there. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
