On Thu, 13 Dec 2012, Dan Carpenter wrote: > On Thu, Dec 13, 2012 at 11:18:53AM +0100, Julia Lawall wrote: > > On Thu, 13 Dec 2012, Dan Carpenter wrote: > > > > > On Wed, Dec 12, 2012 at 01:25:56AM +0400, Evgeniy Polyakov wrote: > > > > I suppose mdev will be automatically freed, but who will release > > > > mdev->clk and other private members of mdev structure? > > > > > > + mdev->clk = devm_clk_get(&pdev->dev, NULL); > > > > > > ->clk is now a devm pointer as well. > > > > Thanks for the suggestion. I will submit a patch shortly. > > > > Huh? I think there is a miscommunication here. I was trying to > explain that your original patch handles releasing ->clk. > > I've reviewed the patch again and I still don't see a problem with > it. What will you change when you resubmit? Oops, sorry. I thought your + mdev->clk = devm_clk_get(&pdev->dev, NULL); was a suggestion of something I had overlooked. Thanks, julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
