On Wed, Dec 05, 2012 at 07:17:16AM -0800, Linus Torvalds wrote: > On Wed, Dec 5, 2012 at 4:44 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > READ is zero so this test is always false. (rw == READ) was intended. > > Actually, that really *is* a bitmask, but yeah, the test is wrong. > > The correct test is > > ((rw & RW_MASK) == READ) > Ah. Of course. I'll send a v2. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html