Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > If we set oobdelta to zero then we will either return -EINVAL or hit > a divide (modulus) by zero on the next line when we check > "(ooblen % oobdelta)". It's better to just return -EINVAL here instead. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > Static analysis. I don't know if it's actually possible to hit this > condition. I don't know any possibility to reach that condition, nonetheless the patch makes the code more robust, therefore : Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html