Re: [patch] Input: wacom - fix a check for WACOM_24HDT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 29, 2012 at 11:49:56AM +0300, Dan Carpenter wrote:
> The current condition is always true.  From the context, it looks like
> we should be checking if ->type == WACOM_24HDT.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thank you Dan, however I already have a patch from Jason Gerecke
addressing this issue.

> 
> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
> index 2c1e12b..858ad44 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -391,7 +391,7 @@ static int wacom_parse_hid(struct usb_interface *intf,
>  							features->pktlen = WACOM_PKGLEN_TPC2FG;
>  						}
>  
> -						if (features->type == MTSCREEN || WACOM_24HDT)
> +						if (features->type == MTSCREEN || features->type == WACOM_24HDT)
>  							features->pktlen = WACOM_PKGLEN_MTOUCH;
>  
>  						if (features->type == BAMBOO_PT) {

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux