On Oct 25, 2012, at 2:33 AM, Dan Carpenter wrote: > On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote: >> On Wed, 24 Oct 2012 14:26:13 -0400 >> Ed Cashin <ecashin@xxxxxxxxxx> wrote: >> >>> After calling dev_queue_xmit it is no longer safe to access the >>> members of the skb. >>> >>> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >> >> hm, that was clever. How did Dan detect this bug? > > It was a Smatch thing, but it wasn't enabled by default. I think I > will enable it. This is the second bug use after dev_queue_xmit() > in two years. OK, no more procrastinating. I'm using smatch from today forward. -- Ed Cashin ecashin@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
