On Wed, 2012-10-10 at 11:42 +0100, David Laight wrote:
> > - unsigned long protos[8] = {0,};
> > + DECLARE_BITMAP(protos, BITS_PER_LONG * 8) = { 0, };
> ...
> > - if ((r = set_arg(argp, protos, 8 * sizeof(long))))
> > + if ((r = set_arg(argp, protos, sizeof(protos))))
>
> That change makes a big assumption about the implementation
> of DECLARE_BITMAP().
> Unless it is guaranteed to be implemented as 'unsigned long[]'
> then you've changed what the code might do.
Possible, but it's hard to imagine it changing.
The = { 0, } should probably be bitmap_zero
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
