Fengguang Wu writes: > > Hi Bill, > > FYI, there are new smatch warnings show up in > > + drivers/staging/dgrp/dgrp_net_ops.c:277 dgrp_input() error: we previously assumed 'ld' could be null (see line 238) This one looks fine, if ld is NULL then len is set to 0. ld is then only dereferenced if len != 0 > -- > + drivers/staging/dgrp/dgrp_specproc.c:273 register_proc_table() error: we previously assumed 'table->child' could be null (see line 263) It seems weird where smatch is seeing the NULL test vs. the call to register_proc_table(), but it is correct that register_proc_table will do bad things if the first arg is a NULL. I'll submit a patch for it. > -- > + drivers/staging/dgrp/dgrp_tty.c:3177 dgrp_tty_init() error: potential null dereference 'nd->nd_serial_ttdriver'. (alloc_tty_driver returns null) > + drivers/staging/dgrp/dgrp_tty.c:3236 dgrp_tty_init() error: potential null dereference 'nd->nd_callout_ttdriver'. (alloc_tty_driver returns null) > + drivers/staging/dgrp/dgrp_tty.c:3273 dgrp_tty_init() error: potential null dereference 'nd->nd_xprint_ttdriver'. (alloc_tty_driver returns null) > Yes, the return value of alloc_tty_driver needs to be checked. I'll fix these. -- Bill -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
