On Sat, Oct 6, 2012 at 10:07 AM, Fengguang Wu <fengguang.wu@xxxxxxxxx> wrote: > Hi Sjur, > > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git for-next > head: d09f53a735bae43806a77754312a45d3f1198342 > commit: ec4d02d9180f407c41f8310a13b34e473c671fbb [7/12] remoteproc: Add STE modem driver > config: x86_64-randconfig-s058 (attached as .config) > > All error/warnings: > > ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined! > ERROR: "register_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined! > ERROR: "unregister_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined! > ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined! > ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined! > ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefined! Thanks, Fengguang, I've pushed this patch to fix this: commit ed26d190a3e7718a6b8a4f844e963b408f54ce32 Author: Ohad Ben-Cohen <ohad@xxxxxxxxxx> Date: Sat Oct 6 11:35:57 2012 +0200 remoteproc: fix (again) the virtio-related build breakage Another virtio dependency was overlooked, so add it to fix the below build breakage. This time for real. ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined! ERROR: "register_virtio_device" [drivers/remoteproc/remoteproc.ko] undefined ERROR: "unregister_virtio_device" [drivers/remoteproc/remoteproc.ko] undefin ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined! ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined! ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefin Cc: stable@xxxxxxxxxxxxxxx Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index 96ce101..209a4a2 100644 --- a/drivers/remoteproc/Kconfig +++ b/drivers/remoteproc/Kconfig @@ -7,6 +7,7 @@ config REMOTEPROC depends on HAS_DMA select FW_CONFIG select VIRTIO + select VIRTIO_RING config OMAP_REMOTEPROC tristate "OMAP remoteproc support" -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html