On 10/05/2012 10:41 PM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin <peter.senna@xxxxxxxxx> > > The function pcan_probe() return 0 for success and negative value > for most of its internal tests failures. There is one exception > that is error case going to probe_err_4:. Fore this error case, the > function abort its success execution path but returns non negative > value, making it difficult for a caller function to notice the error. > > This patch fixes the error case that do not return negative value. > > This was found by Coccinelle, but the code change was made by hand. > This patch is not robot generated. > > A simplified version of the semantic match that finds this problem is > as follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx> Too late, v1 of this patch is already in net/master regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
