On 10/02/2012 01:28 AM, Dan Carpenter wrote:
> This for loop doesn't work correctly when "p" is unsigned.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
My god, yes thanks.
It is a sure overrun crash. I wonder why it never hit till
today.
Thanks will apply ASAP
Boaz
> diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c
> index 5f376d1..b963f38 100644
> --- a/fs/exofs/ore_raid.c
> +++ b/fs/exofs/ore_raid.c
> @@ -203,7 +203,7 @@ static unsigned _sp2d_min_pg(struct __stripe_pages_2d *sp2d)
>
> static unsigned _sp2d_max_pg(struct __stripe_pages_2d *sp2d)
> {
> - unsigned p;
> + int p;
>
> for (p = sp2d->pages_in_unit - 1; p >= 0; --p) {
> struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p];
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
