On 05.08.2012, at 11:52, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Convert a 0 error return code to a negative one, as returned elsewhere in the > function. > > A new label is also added to avoid freeing things that are known to not yet > be allocated. > > A simplified version of the semantic match that finds the first problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier ret; > expression e,e1,e2,e3,e4,x; > @@ > > ( > if (\(ret != 0\|ret < 0\) || ...) { ... return ...; } > | > ret = 0 > ) > ... when != ret = e1 > *x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...); > ... when != x = e2 > when != ret = e3 > *if (x == NULL || ...) > { > ... when != ret = e4 > * return ret; > } > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> Thanks, applied to kvm-ppc-next. Alex -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
