On Sun, 2012-09-30 at 00:10 +0200, Maxim Levitsky wrote:
> On Sat, 2012-09-29 at 10:11 +0300, Dan Carpenter wrote:
> > We need to free "overwrite_flags" before returning.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
> > index a8e8915..1f9d5cf 100644
> > --- a/drivers/memstick/core/ms_block.c
> > +++ b/drivers/memstick/core/ms_block.c
> > @@ -1408,8 +1408,10 @@ static int msb_ftl_scan(struct msb_data *msb)
> > msb_mark_block_used(msb, pba);
> > msb_erase_block(msb, pba);
> > continue;
> > - } else if (error)
> > + } else if (error) {
> > + kfree(overwrite_flags);
> > return error;
> > + }
> >
> > lba = be16_to_cpu(extra.logical_address);
> > managment_flag = extra.management_flag;
>
> Indeed. I need to be more careful with this,
> I'll do another review of the code, maybe I spot anything else.
>
> Acked-by: Maxim Levitsky <maximlevitsly@xxxxxxxxx>
maximlevitsky@xxxxxxxxx> :-(
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
