Re: [patch] HID: picoLCD: fix a NULL test in picolcd_raw_cir()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 7 Sep 2012, Bruno Prémont wrote:

> > Smatch complains that the NULL checking in this function is not
> > consistent and could lead to a NULL dereference.  The comments say that
> > we should return here if rc_dev is NULL so I've changed the test to
> > match the comment.
> 
> Good catch! Currently thanks to HID mutex around probe()/remove()
> we should never be able to see rc_dev being NULL here.
> 
> 
> Once the probe()/remove() mutex gets tied to hw_start()/hw_stop() or
> otherwise changed to allow drivers to chat with device during probe()
> ->rc_dev might be NULL in picolcd_raw_cir().
> 
> 
> Reviewed-by: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx>

Applied, thanks Dan, thanks Bruno.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux