RE: [mac80211-next:wip 56/57] net/mac80211/mlme.c:903:43: warning: 'chan_pwr' may be used uninitialized in this function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon':
> > > net/mac80211/mlme.c:903:43: warning: 'chan_pwr' may be used
> > > uninitialized in this function [-Wmaybe-uninitialized]
> > > net/mac80211/mlme.c:871:6: note: 'chan_pwr' was declared here
> >
> > I think this is a false positive? It's only used if have_chan_pwr is true, and
> that's set only if chan_pwr is set.
> 
> Yes..many of the compiler warnings are false ones. They are sent out anyway
> because I believe it's good practice to just quiet *all* gcc warnings.
> 
> Would you apply the followed fix?

No. I don't believe that we should arbitrarily shut up gcc warnings by doing things like this as it may very well shut up legitimate warnings in the future. Also, newer gccs (like my 4.7.1) don't warn here.

johannes
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux