On Thu, Sep 06, 2012 at 03:40:20PM +0300, Dan Carpenter wrote: > If "pool_id" is negative then it leads to a read before the start of the > array. If "cli_id" is out of bounds then it leads to a NULL dereference > of "cli". GCC would have warned about that bug except that we > initialized the warning message away. > > Also it's better to put the parameter names into the function > declaration in the .h file. It serves as a kind of documentation. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > BTW, This file has a ton of GCC warnings. This function returns -1 > on error which is a nonsense return code but the return value is not > checked anyway. *Grumble*. I agree, it's very messy. Dan Magenheimer should have known better, and he better be sending me a patch soon to remove these warnings (hint...) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
