On Wed, Sep 05, 2012 at 04:42:03PM -0700, Dan Carpenter wrote: > The dereference happens inside the assignment. Yes, this: #define list_for_each_entry_reverse(pos, head, member) \ for (pos = list_entry((head)->prev, typeof(*pos), member); \ &pos->member != (head); \ <--- DEREF. pos = list_entry(pos->member.prev, typeof(*pos), member)) but we kfree pos aka p after the deref and in the next iteration p becomes the list entry of the next list element, AFAICT. > That's actually the reason why we have the the _safe() version of the > macro. _safe, the way I see it, is for concurrent list manipulations and at the point we free the cache, I don't see us concurrently manipulating that list. So, sorry, but I don't see the problem. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
