Hi Girish, Sorry for taking a really long time to respond! This is a good idea, but your patch doesn't apply any more. Can you update it against the latest kernel and resend it? Sarah Sharp On Sun, May 13, 2012 at 08:59:02PM +0530, Girish Verma wrote: > In xhci-ring.c, function inc_enq and inc_deq calculate the dma address > of trb but never used. > > Signed-off-by: Girish Verma <girish@xxxxxxxxxxxxxxxx> > --- > drivers/usb/host/xhci-ring.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > index 3d9422f..dcd67c1 100644 > --- a/drivers/usb/host/xhci-ring.c > +++ b/drivers/usb/host/xhci-ring.c > @@ -146,7 +146,6 @@ static void next_trb(struct xhci_hcd *xhci, > static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring) > { > union xhci_trb *next; > - unsigned long long addr; > > ring->deq_updates++; > > @@ -168,7 +167,6 @@ static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring) > ring->dequeue = ring->deq_seg->trbs; > next = ring->dequeue; > } > - addr = (unsigned long long) xhci_trb_virt_to_dma(ring->deq_seg, ring->dequeue); > } > > /* > @@ -193,7 +191,6 @@ static void inc_enq(struct xhci_hcd *xhci, struct xhci_ring *ring, > { > u32 chain; > union xhci_trb *next; > - unsigned long long addr; > > chain = le32_to_cpu(ring->enqueue->generic.field[3]) & TRB_CHAIN; > /* If this is not event ring, there is one less usable TRB */ > @@ -245,7 +242,6 @@ static void inc_enq(struct xhci_hcd *xhci, struct xhci_ring *ring, > ring->enqueue = ring->enq_seg->trbs; > next = ring->enqueue; > } > - addr = (unsigned long long) xhci_trb_virt_to_dma(ring->enq_seg, ring->enqueue); > } > > /* > -- > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html