On Tue, 2012-09-04 at 11:44 +0200, Julia Lawall wrote: > > I've been bitten by the same issue recently, also cause by one of these > > cocci devm patches. devm_clk_get is only available if the generic > > clk_get/clk_put implementation is used. Not all architectures do this and > > some implement their own clk_get/clk_put, etc functions. Since devm_clk_get > > is merely a wrapper around clk_get/clk_put there is no reason why it should > > depend CLKDEV_LOOKUP. I've prepared a patch which makes them generically > > available if the clk_get/clk_put are implemented (i.e. if HAVE_CLK is set), > > but it is on a different machine right now, will try to submit it later today. > > Sorry about this. I wasn't aware that devm_clk_get wasn't supported by > all architectures, and I have no way of compiling code for these > architectures... But I wonder why it is not, since devm-ness doesn't seem > to have anything to do with architecture-specific details? It would be > really nice to have it for all architectures, because the clock functions > are just as (or at least almost as) common as kzalloc, ioremap, etc. It looks like Lars is going to fix this. I am personally fine if you send patches without build-testing them. Your patches are generally of good quality and you send many of them, so build-testing each would be too much for you. And at least for MTD, I can build-test myself. -- Best Regards, Artem Bityutskiy
Attachment:
signature.asc
Description: This is a digitally signed message part
