RE: [staging-next V3] ozwpan: fix memcmp() test in oz_set_active_pd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



________________________________________
From: Tomas Winkler [tomas.winkler@xxxxxxxxx]
Sent: 19 August 2012 17:36
To: gregkh@xxxxxxxxxxxxxxxxxxx
Cc: alan@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; Tomas Winkler; Dan Carpenter; Rupesh Gujare
Subject: [staging-next V3] ozwpan: fix memcmp() test in oz_set_active_pd()

"addr" is a pointer so it's either 4 or 8 bytes, but actually we want
to compare 6 bytes (ETH_ALEN).

As network stack already provides helper function
is_zero_ether_addr() we use that instead of memcmp

Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Cc: Rupesh Gujare <rgujare@xxxxxxxxxxxxxxx>
---
V1: by Dan Carpenter <dan.carpenter@xxxxxxxxxx>
V2: replace memcmp with is_zero_ether_addr
V3: include <linux/etherdevice.h>

Acked-by: Rupesh Gujare<rgujare@xxxxxxxxxxxxxxx> 


--
Regards,
Rupesh Gujare
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux