On 08/19/2012 10:03 AM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > It was forgotten to initialize ret to the result of calling > snd_soc_dai_set_sysclk, unlike at the other calls in the same function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- > sound/soc/omap/am3517evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/omap/am3517evm.c b/sound/soc/omap/am3517evm.c > index 009533a..df65f98 100644 > --- a/sound/soc/omap/am3517evm.c > +++ b/sound/soc/omap/am3517evm.c > @@ -59,7 +59,7 @@ static int am3517evm_hw_params(struct snd_pcm_substream *substream, > return ret; > } > > - snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_FSR_SRC_FSX, 0, > + ret = snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_FSR_SRC_FSX, 0, > SND_SOC_CLOCK_IN); > if (ret < 0) { > printk(KERN_ERR "can't set CPU system clock OMAP_MCBSP_FSR_SRC_FSX\n"); > Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
