Re: [patch] sctp: fix bogus if statement in sctp_auth_recv_cid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:

> There is an extra semi-colon here, so we always return 0 instead of
> calling __sctp_auth_cid().

Doh.

Reviewed-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Only needed for linux-next.
>
> diff --git a/net/sctp/auth.c b/net/sctp/auth.c
> index aaa6c12..159b9bc 100644
> --- a/net/sctp/auth.c
> +++ b/net/sctp/auth.c
> @@ -695,7 +695,7 @@ int sctp_auth_recv_cid(sctp_cid_t chunk, const struct sctp_association *asoc)
>  		return 0;
>  
>  	net = sock_net(asoc->base.sk);
> -	if (!net->sctp.auth_enable);
> +	if (!net->sctp.auth_enable)
>  		return 0;
>  
>  	return __sctp_auth_cid(chunk,
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux