On Mon, Aug 13, 2012 at 7:09 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Mon, Aug 13, 2012 at 9:44 AM, Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>> ---
>> drivers/video/mx3fb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
>> index c89f8a8..1dfdeb1 100644
>> --- a/drivers/video/mx3fb.c
>> +++ b/drivers/video/mx3fb.c
>> @@ -771,7 +771,7 @@ static int __set_par(struct fb_info *fbi, bool lock)
>> if (fbi->var.sync & FB_SYNC_SHARP_MODE)
>> mode = IPU_PANEL_SHARP_TFT;
>>
>> - dev_dbg(fbi->device, "pixclock = %ul Hz\n",
>> + dev_dbg(fbi->device, "pixclock = %u Hz\n",
>> (u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL));
>
> I think a better fix is to change the dyslectic "%ul" to "%lu", and
> drop the cast to
> u32, which was probably only added to kill the compiler warning caused by the
> dyslectia issue.
BTW, 'git grep "%ul"' shows a few more of these dyslectia issues.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
