Re: [patch] Staging: xgifb: fix bitwise vs logical bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, 14. August 2012, 09:04:45 schrieb Dan Carpenter:
> This is a static checker fix and not something I can test.  The intent
> of the code here is to set some bit flags.  For a logical OR the ">> 1"
> shift wouldn't make a difference.  So it should be using a bitwise OR.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
I guess this is correct.

Reviewed-by: Peter Huewe <peterhuewe@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux