Re: [patch] ALSA: cs46xx - signedness bug in snd_cs46xx_codec_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Fri, 10 Aug 2012 12:22:58 +0300,
Dan Carpenter wrote:
> 
> This function returns its own error codes instead of normal negative
> error codes.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks, applied now.


Takashi

> 
> diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c
> index f75f5ff..a71d1c1 100644
> --- a/sound/pci/cs46xx/cs46xx_lib.c
> +++ b/sound/pci/cs46xx/cs46xx_lib.c
> @@ -94,7 +94,7 @@ static unsigned short snd_cs46xx_codec_read(struct snd_cs46xx *chip,
>  
>  	if (snd_BUG_ON(codec_index != CS46XX_PRIMARY_CODEC_INDEX &&
>  		       codec_index != CS46XX_SECONDARY_CODEC_INDEX))
> -		return -EINVAL;
> +		return 0xffff;
>  
>  	chip->active_ctrl(chip, 1);
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux