[patch] hwmon: (f71882fg) Signedness bug in f71882fg_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"address" stores and unsigned short on success but a negative on failure
so it needs to be an int.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
Applies to linux-next.  This was introduced in 1f7f944 "hwmon:
(f71882fg) Fix build warning".

diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
index b6304eb..853f544 100644
--- a/drivers/hwmon/f71882fg.c
+++ b/drivers/hwmon/f71882fg.c
@@ -2662,7 +2662,7 @@ exit_device_put:
 static int __init f71882fg_init(void)
 {
 	int err = -ENODEV;
-	unsigned short address;
+	int address;
 	struct f71882fg_sio_data sio_data;
 
 	memset(&sio_data, 0, sizeof(sio_data));
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux