[josef-btrfs:master 12/16] fs/btrfs/inode.c:78:19: sparse: symbol 'btrfs_dip_cachep' was not declared. Should it be static?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Josef,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master
head:   1529b67c68e0ac3123a831815c26211d801ab975
commit: 3f1d28fc7d56b5b6c77af4ca1f258dacdd508ce4 [12/16] Btrfs: use a slab for btrfs_dio_private

All sparse warnings:

+ fs/btrfs/inode.c:78:19: sparse: symbol 'btrfs_dip_cachep' was not declared. Should it be static?

vim +78 fs/btrfs/inode.c
    75	struct kmem_cache *btrfs_transaction_cachep;
    76	struct kmem_cache *btrfs_path_cachep;
    77	struct kmem_cache *btrfs_free_space_cachep;
  > 78	struct kmem_cache *btrfs_dip_cachep;
    79	
    80	#define S_SHIFT 12
    81	static unsigned char btrfs_type_by_mode[S_IFMT >> S_SHIFT] = {

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@xxxxxxxxxxxxxxx>                     Intel Corporation
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 351dd3b..7ab714f 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -75,7 +75,7 @@ struct kmem_cache *btrfs_trans_handle_cachep;
 struct kmem_cache *btrfs_transaction_cachep;
 struct kmem_cache *btrfs_path_cachep;
 struct kmem_cache *btrfs_free_space_cachep;
-struct kmem_cache *btrfs_dip_cachep;
+static struct kmem_cache *btrfs_dip_cachep;
 
 #define S_SHIFT 12
 static unsigned char btrfs_type_by_mode[S_IFMT >> S_SHIFT] = {

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux