On 08/06/2012 04:26 PM, Dan Carpenter wrote: > On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote: >> On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote: >>> @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev) >>> >>> platform_set_drvdata(pdev, pcdev); >>> >>> - if (devm_request_mem_region(&pdev->dev, res_emma->start, >>> - resource_size(res_emma), MEM2MEM_NAME) == NULL) >>> - goto rel_vdev; >>> - >>> - pcdev->base_emma = devm_ioremap(&pdev->dev, res_emma->start, >>> - resource_size(res_emma)); >>> + pcdev->base_emma = devm_request_and_ioremap(&pdev->dev, res_emma); >>> if (!pcdev->base_emma) >>> goto rel_vdev; >> >> This was in the original code, but there is a "ret = -ENOMEM;" >> missing here, and again a couple lines down in the original code. >> > > Or should that be -EIO instead of -ENOMEM? I'm not sure. -ENXIO is usually used in such a case. - Lars -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
