Hi Julia, On Sat, 4 Aug 2012 19:10:48 +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Converting kzalloc to devm_kzalloc simplifies the code and ensures that the > result, alert, is freed after the irq allocated by the subsequent > devm_request_irq. This in turn ensures that when an interrupt can be > triggered, the alert structure is still available. Good point. I honestly have no idea why this driver's resources are half managed, it doesn't make much sense... Patch applied, with a comment clarified, thanks. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html